[MISC] Reusable workflow #168
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| { | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": ["github>canonical/data-platform//renovate_presets/charm.json5"], | ||
| "reviewers": ["dragomirp", "marceloneppel", "taurus-forever"], | ||
| "packageRules": [ | ||
| // Later rules override earlier rules | ||
| { | ||
| "matchPackageNames": ["pydantic"], | ||
| "allowedVersions": "<2.0.0" | ||
| }, { | ||
| "matchPackageNames": ["python"], | ||
| "allowedVersions": "<3.11" | ||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. consider disabling python updates instead—maybe we should add this to shared config There was a problem hiding this comment. The python version is charm specific, it will vary depending on the base. There was a problem hiding this comment. My suggestion is to disable automatic python updates for all charms |
||
| } | ||
| ], | ||
| "regexManagers": [ | ||
| { | ||
| "fileMatch": ["(^|/)([\\w-]*)charmcraft\\.ya?ml$"], | ||
| "matchStrings": ["- (?<depName>.*?)(?:\\[.*?\\])?==(?<currentValue>.*?) +# renovate"], | ||
| "datasourceTemplate": "pypi", | ||
| "versioningTemplate": "loose" | ||
| } | ||
| ] | ||
|
There was a problem hiding this comment. fyi charm-strict-dependencies will change how binary packages are managed would recommend enabling strict dependencies if they don't cause issues |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,6 @@ build/ | |
| .coverage | ||
| __pycache__/ | ||
| *.py[cod] | ||
| *.log | ||
| /requirements.txt | ||
| /requirements-last-build.txt | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permanent ignores for temporary issues make me worried that we'll forget about them
maybe a better option would be to manually close the PR that renovate opens so that it adds it to the ignore list?
at the least, I'd suggest adding a comment to explain why this ignore was added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider this a temporary issue. There are multiple charm libs that will need to be updated to work with pydantic 2 and it also fails to compile with focal's rustc. I doubt we can make the jump anytime soon.