Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] PR to collect feedback on charmhub listing request #283

Closed
wants to merge 1 commit into from

Conversation

lucasgameiroborges
Copy link
Member

Issue

In order to publicly list this charm to charmhub, we would like to collect feedback on it via this PR

Solution

Open this PR to collect feedback on the charm

Copy link

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

I left some minor comments that will be nice to be addressed.

As general notes I will update copyright date on each file.

After these changes it will be fine with me!

- Generally, before developing enhancements to this charm, you should consider [opening an issue
](https://github.com/canonical/pgbouncer-k8s-operator/issues) explaining your use case.
- If you would like to chat with us about your use-cases or proposed implementation, you can reach
us at [Canonical Mattermost public channel](https://chat.charmhub.io/charmhub/channels/charm-dev)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update from Mattermost to Matrix

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Licence details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants