Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC] Use preset renovate configuration #316

Merged
merged 5 commits into from
Jun 27, 2024
Merged

[MISC] Use preset renovate configuration #316

merged 5 commits into from
Jun 27, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Jun 20, 2024 •
edited
Loading

  • Converge on shared renovate config.
  • Update charm libraries

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (030de60) to head (7d344ef).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files           8        8           
  Lines        1167     1167           
  Branches      213      213           
=======================================
  Hits          821      821           
  Misses        269      269           
  Partials       77       77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 25, 2024
View reviewed changes
lib/charms/tempo_k8s/v1/charm_tracing.py Dismissed Show dismissed Hide dismissed
dragomirp
dragomirp commented Jun 25, 2024
View reviewed changes
.github/renovate.json5
Comment on lines +25 to 27
"depNameTemplate": "juju",
"datasourceTemplate": "pypi",
"versioningTemplate": "loose"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lib juju 2 is the only custom config left.

@dragomirp dragomirp marked this pull request as ready for review June 25, 2024 20:21
taurus-forever
taurus-forever approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dragomirp dragomirp merged commit 96c62d1 into main Jun 27, 2024
47 checks passed
@dragomirp dragomirp deleted the use-renovate-preset branch June 27, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marceloneppel marceloneppel marceloneppel approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@lucasgameiroborges lucasgameiroborges Awaiting requested review from lucasgameiroborges

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragomirp @taurus-forever @marceloneppel