-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-4062] Improve displayed error message if charm was deployed without --trust
flag
#319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 70.35% 70.63% +0.28%
==========================================
Files 8 8
Lines 1167 1192 +25
Branches 213 218 +5
==========================================
+ Hits 821 842 +21
+ Misses 269 268 -1
- Partials 77 82 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for the changes. We should try to keep Codecov happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I will, I'm still not done with the changes tho. It's still in draft!! :P You are too fast!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
K8s charms that create resources in a RBAC enabled environment need to be deployed with the
--trust
flag, otherwise they don't work. If a user deploys PGB k8s charm without that flag, there is no clear message indicating the issue.Solution
--trust
.lightkube.Client().get
is used. Maybe overkill, but better safe than sorry, I think?