Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple endpoint support #28

Merged
merged 8 commits into from
Nov 19, 2024
Merged

multiple endpoint support #28

merged 8 commits into from
Nov 19, 2024

Conversation

PietroPasotti
Copy link
Collaborator

@PietroPasotti PietroPasotti commented Nov 14, 2024 •
edited
Loading

Fixes #27

Kinda hard to test, might want to create a better mock charm.

Manual testing strategy:
check out a charm that has multiple endpoints with the same interface on a single role, then pin this branch in your requirements.txt:

"pytest-interface-tester@git+http://github.com/canonical/pytest-interface-tester@multiple-endpoint-support",

@PietroPasotti PietroPasotti marked this pull request as ready for review November 14, 2024 16:12
tonyandrewmeyer
tonyandrewmeyer reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A bit unsure about the test case.

Also re: testing, if I'm understanding correctly and we'll now test all endpoints with matching interfaces, should we have a test that does have more than one?

pyproject.toml Outdated Show resolved Hide resolved
interface_tester/interface_test.py Outdated Show resolved Hide resolved
tests/unit/test_e2e.py Outdated Show resolved Hide resolved
tonyandrewmeyer
tonyandrewmeyer approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PietroPasotti PietroPasotti merged commit 87e4bbf into main Nov 19, 2024
2 checks passed
@PietroPasotti PietroPasotti deleted the multiple-endpoint-support branch November 19, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support testing multiple endpoints with the same interface name
2 participants
@PietroPasotti @tonyandrewmeyer