-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove useEffects #707
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the following error when building the NMS (it was not there before) :
ReferenceError: location is not defined
at s (.next/server/app/page.js:1:3006)
Error fetching Swagger specs: TypeError: Failed to parse URL from swagger/doc.json
at <unknown> (.next/server/chunks/638.js:2:6875)
at K (.next/server/chunks/638.js:2:13357)
at <unknown> (.next/server/chunks/638.js:2:16319)
at async (.next/server/app/(api)/api/page.js:1:3678) {
[cause]: TypeError: Invalid URL
at <unknown> (.next/server/chunks/638.js:2:6875)
at K (.next/server/chunks/638.js:2:13357)
at <unknown> (.next/server/chunks/638.js:2:16319)
at async (.next/server/app/(api)/api/page.js:1:3678) {
code: 'ERR_INVALID_URL',
input: 'swagger/doc.json'
}
}
The access to the swagger page seems fine onces it's running. I think it tries to access to the page during building when it does not exist yet because it comes from the webconsole, and the webconsole is not there yet?
I am running into a issue when editing the subscribers:
If I have 2 subscribers and I edit one of them to change the DG, only the one I edited disappears from the list. |
There is way to run this command only in the server side. But it did not work for me. At the moment, I only can suppress it. I am still looking for a reasonable solution. Reverting this file can also be an option. |
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
Signed-off-by: gatici <gulsum.atici@canonical.com>
ef90d28
to
9a7f8d1
Compare
I tested the subscriber edition using official image and the following scenario is not possible. Please see #711.
|
Description
This PR reduces the usage of useEffect in the NMS.
useEffect is removed from 4 different places and useQuery is used.
Checklist: