extensions: support for content sharing for ROS

[artivis]

This PR introduces the support of content sharing for ROS together with a few extensions that make building a ROS content sharing snap seamless.

To that effect several snaps meant to distribute ROS through content-sharing were created and are available on the store (hidden, e.g. ros-foxy-ros-base & ros-foxy-ros-base-dev)

This PR is large as it concerns,

• core20 & 22 (ROS Noetic, Foxy, Humble)
• colcon, catkin, catkin-tools plugins

To note:

• requires the 'dev' snap providing the build-time material to execute a script listing all ROS packages it contains when it's built

• Have you followed the guidelines for contributing?

• Have you signed the CLA?

• Have you successfully run make lint?

• Have you successfully run pytest tests/unit?

---

[artivis]

Not sure why pyright is failing here. It seems unrelated to this PR tho. If anyone has a pointer?

[mr-cal]

Tracking with CRAFT-1848

[mr-cal]

Looks good! I have no concerns with the design or implementation. My feedback is minor and related to linters and best practices.

I see two blockers:

1. You will need to resolve the conflicts with the main branch
2. You will need to rebase onto Sergio's upcoming feature to make extensions part plugin aware (scheduled for this pulse)

[artivis]

I see two blockers:

1. You will need to resolve the conflicts with the main branch
2. You will need to rebase onto Sergio's upcoming feature to make extensions part plugin aware (scheduled for this pulse)

Would you prefer that I merge or rebase?

[mr-cal]

Would you prefer that I merge or rebase?

No preference. It will get squash-merged in the end, so whichever path is easier for you is fine.

[mr-cal]

#4271 contains the functionality for extensions to be part plugin aware

[codecov-commenter]

Codecov Report

Merging #4221 (43e3aa2) into main (9680075) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 84.85%.

❗ Current head 43e3aa2 differs from pull request most recent head b08702e. Consider uploading reports for the commit b08702e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4221      +/-   ##
==========================================
- Coverage   89.20%   89.13%   -0.07%     
==========================================
  Files         300      315      +15     
  Lines       20639    21037     +398     
==========================================
+ Hits        18410    18752     +342     
- Misses       2229     2285      +56     

Files Changed	Coverage Δ
snapcraft_legacy/plugins/v2/_ros.py	48.06% <35.89%> (-3.56%)	⬇️
snapcraft/parts/plugins/_ros.py	51.06% <39.47%> (-4.18%)	⬇️
...oject_loader/_extensions/ros1_noetic_perception.py	87.50% <87.50%> (ø)
...al/project_loader/_extensions/ros1_noetic_robot.py	87.50% <87.50%> (ø)
...project_loader/_extensions/ros1_noetic_ros_base.py	87.50% <87.50%> (ø)
...project_loader/_extensions/ros1_noetic_ros_core.py	87.50% <87.50%> (ø)
...l/project_loader/_extensions/ros2_foxy_ros_base.py	87.50% <87.50%> (ø)
...l/project_loader/_extensions/ros2_foxy_ros_core.py	87.50% <87.50%> (ø)
...al/project_loader/_extensions/_ros1_noetic_meta.py	93.93% <93.93%> (ø)
...rnal/project_loader/_extensions/_ros2_foxy_meta.py	96.29% <96.29%> (ø)
... and 12 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[artivis]

The PR was rebased on top of main and thus on top of #4271.

Note that I had to disable the test_extensions_all_combinations_validate test which execution exploded with the addition of the new extensions in this PR.

[mr-cal]

+1, I have no further concerns.

[MirkoFerrati]

@sergiusens @mr-cal what's the ETA on merging this? can we help somehow?
I see there are still 2 unresolved conversations, are those the blockers?

[MirkoFerrati]

@sergiusens any update here?

[mr-cal]

@sergiusens @mr-cal what's the ETA on merging this? can we help somehow? I see there are still 2 unresolved conversations, are those the blockers?

Hey @MirkoFerrati, sorry I missed your ping. Since Sergio and I both approved this, I'll get it merged today.

[sergiusens]

@MirkoFerrati sorry about that, this should have been merged when I merged back main back then

[MirkoFerrati]

@sergiusens no worries, I didn't want to spam with the pings as I didn't know the status. Next time I see "main" merged in the PR branch I will know how it works and ping you more often! Thanks for the fast response today!

[sergiusens]

@MirkoFerrati no sweat, re-requesting review also works as it shows up in our review queue more prominently