Hotfix/7.5 merge #4281
Closed
Hotfix/7.5 merge #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
godeps can not longer build due to golang/go#57051 Instead of removing the godeps feature, disable the tests in case the upstream fixes the problem.
The new version supports asset files that contain more than one key (for whatever reason). This is more in line with the behavior done by the previous implementation (via apt-key). Closes #4224
remove extra build environment variables that are causing build failures. Co-authored-by: Scarlett Gately Moore <sgmoore@debian.org>
This commit adds a spread test to check the "Set up classic confinement for a Python project" tutorial. As an overview, the test: - runs specifically on Ubuntu 20.04 systems; - clones the test repo from snapcraft-docs/python-ctypes-example; - builds & installs the snap from the test repo; - runs the snap on the 20.04 system, to ensure the patchelf fix is working in the presence of the classic confinement. Co-authored-by: Callahan <callahan.kovacs@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Version 1.1.2 allows local package repositories (those with scheme `url: file:///...`) again.
snapcraft-started-at is a manifest field. This suggests that upload never sent built_at because it was trying to extract it from meta/snap.yaml instead of snap/manifest.yaml. The unused before this change test file test-snap-with-started-at.snap was updated accordingly: - snapcraft-started-at field was removed from meta/snap.yaml, - and a new snap/manifest.yaml was added. The change was tested against the Store. Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> Co-authored-by: Callahan <callahan.kovacs@canonical.com>
This reverts commit 0e12894.
This reverts commit ce23bc7.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4281 +/- ##
==========================================
+ Coverage 88.98% 89.10% +0.12%
==========================================
Files 296 299 +3
Lines 20194 20640 +446
==========================================
+ Hits 17970 18392 +422
- Misses 2224 2248 +24
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?