projects: Add support for custom data #4282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-costas
force-pushed
the
DT-1273-add-support-for-custom-extensions-in-snapcrafts-yaml-files
branch
3 times, most recently
from
d1321b6
to
48ed9a7
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4282 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 296 296
Lines 20208 20227 +19
=======================================
+ Hits 17984 18001 +17
- Misses 2224 2226 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sergio-costas
changed the title
This patch implements proposal ST090. It allows to add custom metadata into the snapcraft.yaml files without interferring with snapcraft. This is useful for adding extra data for tools that manage snap files, like updatesnap.py, which searches for new versions of the parts in a snapcraft.yaml file. Proposal: https://docs.google.com/document/d/1QX0moP6V709D7L267pIT5AREQetbPb7KsFrpgvCLKVM
sergio-costas
force-pushed
the
DT-1273-add-support-for-custom-extensions-in-snapcrafts-yaml-files
branch
from
075e8c8
to
0fa2d76
Compare
|
Out of curiosity, why are you not using renovate to handle these things? |
|
@sergiusens Ehm... well, I presume that this is the moment where I discover that there is already a tool for what I needed... What is "renovate"? |
|
https://github.com/renovatebot/renovate Closing this for now, as this seems out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements proposal ST090. It allows to add custom metadata into the snapcraft.yaml files without interferring with snapcraft. It works both in legacy and modern files.
This is useful for adding extra data for tools that manage snap files, like updatesnap.py, which searches for new versions of the parts in a snapcraft.yaml file.
Proposal document: https://docs.google.com/document/d/1QX0moP6V709D7L267pIT5AREQetbPb7KsFrpgvCLKVM
make lint?pytest tests/unit?