Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: prioritize --use-lxd over SNAPCRAFT_BUILD_ENVIRONMENT #4329

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Aug 18, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Prioritize the command line argument --use-lxd over the environment variable SNAPCRAFT_BUILD_ENVIRONMENT=host.

Resolves #4307
(CRAFT-1956)

Prioritize the command line argument `--use-lxd` over the
environment variable `SNAPCRAFT_BUILD_ENVIRONMENT=host`.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Merging #4329 (9af8987) into main (4f13298) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4329   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         300      300           
  Lines       20623    20623           
=======================================
  Hits        18378    18378           
  Misses       2245     2245           
Files Changed Coverage Δ
snapcraft/parts/lifecycle.py 92.90% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

snapcraft/parts/lifecycle.py Outdated Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the reorganization it's easy to see that the set of conditions effectively means "use provider".

@mr-cal mr-cal merged commit 7f8d4cf into main Aug 22, 2023
11 checks passed
@mr-cal mr-cal deleted the cli-use-lxd branch August 22, 2023 14:34
jardon pushed a commit to jardon/snapcraft that referenced this pull request Sep 6, 2023
…ical#4329)

Prioritize the command line argument `--use-lxd` over the
environment variable `SNAPCRAFT_BUILD_ENVIRONMENT=host`.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNAPCRAFT_BUILD_ENVIRONMENT apparently takes precedence over "--use-lxd"
3 participants