enable "streaming brief" CLI mode #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigarmo
force-pushed
the
work/enable-streaming-brief
branch
from
6c7c1ee
to
c3d94db
Compare
lengau
reviewed
Aug 23, 2023
mr-cal
approved these changes
Aug 24, 2023
These are updates to use the new "streaming brief" feature from craft-cli, but the feature itself is not enabled by this commit.
tigarmo
force-pushed
the
work/enable-streaming-brief
branch
from
c3d94db
to
194e182
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4331 +/- ##
==========================================
+ Coverage 89.09% 89.11% +0.01%
==========================================
Files 299 300 +1
Lines 20582 20623 +41
==========================================
+ Hits 18338 18378 +40
- Misses 2244 2245 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tigarmo
changed the title
sergiusens
approved these changes
Aug 25, 2023
|
this is a great improvement! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit has the version bumps and fixes from the craft-providers bump (not sure if those were expected)
Second commit has the actual enablement of the feature
The changes themselves are ready for review, but still need to:
... so I'm keeping it as a draft for now. The test failures are related to the needed merge
Fixes #4317