Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parts): move yaml utils out of lifecycle #4338

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Aug 29, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Move 4 snapcraft.yaml utility functions out of lifecycle module into the yaml_utils module. No functional changes.

I've been wanting to do this for some time. Working on #4318 is an excuse to get it done since it requires importing these functions.

(CRAFT-1972)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested review from cmatsuoka and syu-w August 29, 2023 21:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #4338 (b2d7c7b) into main (9ad7a93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4338   +/-   ##
=======================================
  Coverage   89.11%   89.12%           
=======================================
  Files         300      300           
  Lines       20631    20635    +4     
=======================================
+ Hits        18386    18390    +4     
  Misses       2245     2245           
Files Changed Coverage Δ
snapcraft/commands/discovery.py 91.48% <100.00%> (ø)
snapcraft/commands/extensions.py 100.00% <100.00%> (ø)
snapcraft/commands/init.py 100.00% <100.00%> (ø)
snapcraft/commands/lint.py 100.00% <100.00%> (ø)
snapcraft/commands/remote.py 79.48% <100.00%> (ø)
snapcraft/parts/lifecycle.py 91.82% <100.00%> (-1.09%) ⬇️
snapcraft/parts/yaml_utils.py 96.66% <100.00%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@mr-cal mr-cal merged commit fb2777f into main Aug 30, 2023
11 checks passed
@mr-cal mr-cal deleted the yaml-refactor branch August 30, 2023 15:26
jardon pushed a commit to jardon/snapcraft that referenced this pull request Sep 6, 2023
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants