chore: remove unused list_registered legacy code #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
approved these changes
Sep 1, 2023
This code has since been ported to the newer instances as a Craft CLI command "names", which uses a newer implementation that does not have any reference to price. With this we remove the last references to Price, even if unused. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
dead-price
branch
from
f64f729
to
f1e4e20
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4345 +/- ##
==========================================
+ Coverage 89.12% 89.15% +0.02%
==========================================
Files 300 300
Lines 20637 20629 -8
==========================================
- Hits 18392 18391 -1
+ Misses 2245 2238 -7
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmatsuoka
approved these changes
Sep 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has since been ported to the newer instances as a Craft CLI command "names", which uses a newer implementation that does not have any reference to price.
With this we remove the last references to Price, even if unused.
make lint?pytest tests/unit?Fixes #4296