Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate dev environment to ubuntu 22.04 and python 3.10 #4425

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 25, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Update the dev environment to Ubuntu 22.04 and Python 3.10.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #4425 (9a1ed03) into main (927f66c) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 84.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #4425      +/-   ##
==========================================
+ Coverage   89.16%   89.18%   +0.01%     
==========================================
  Files         321      322       +1     
  Lines       21608    21659      +51     
==========================================
+ Hits        19267    19316      +49     
- Misses       2341     2343       +2     
Files Coverage Δ
snapcraft/commands/extensions.py 100.00% <100.00%> (ø)
snapcraft/elf/_elf_file.py 97.17% <100.00%> (ø)
snapcraft/meta/appstream.py 99.15% <100.00%> (ø)
snapcraft/meta/manifest.py 72.09% <100.00%> (ø)
snapcraft/meta/snap_yaml.py 97.24% <100.00%> (ø)
snapcraft/parts/lifecycle.py 91.82% <100.00%> (ø)
snapcraft/store/_legacy_account.py 82.47% <100.00%> (ø)
snapcraft/utils.py 91.57% <100.00%> (ø)
snapcraft/parts/grammar.py 96.00% <66.66%> (-4.00%) ⬇️
snapcraft/parts/parts.py 81.75% <50.00%> (ø)
... and 1 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mr-cal mr-cal requested a review from a team October 26, 2023 12:54
@stephensp
Copy link
Contributor

@mr-cal I pulled down this change and tried to run the local tests described in HACKING.md. I frequently seeing this error:

ROOT: provision> .tox/.tox/bin/python -m tox run -e py310-unit
ROOT: HandledError| provided environments not found in configuration file:
py310-unit

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal requested a review from a team October 27, 2023 15:44
Copy link
Contributor

@stephensp stephensp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested these changes and the new container fixes the previous failures we were seeing when running local tests.

@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 30, 2023

Store spread test failure is unrelated (#4411)

@mr-cal mr-cal merged commit f6bbea5 into main Oct 30, 2023
9 of 10 checks passed
@mr-cal mr-cal deleted the hacking-update branch October 30, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants