Add contributor listing #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ru-fu
force-pushed
the
DOCPR-519-contributors
branch
from
94af02d
to
11ad6c6
Compare
ru-fu
force-pushed
the
DOCPR-519-contributors
branch
from
11ad6c6
to
956485b
Compare
rkratky
approved these changes
Jul 25, 2024
sp-files/.sphinx/requirements.txt
Outdated
| @@ -1,2 +1,2 @@ | |||
| canonical-sphinx | |||
| git+https://github.com/canonical/canonical-sphinx@refs/pull/25/merge#egg=canonical-sphinx | |||
There was a problem hiding this comment.
Now that canonical/canonical-sphinx-extensions#41 is merged, do we still want to reference the PR?
There was a problem hiding this comment.
This one is for canonical/canonical-sphinx#25 - but this has now been merged as well. :)
There was a problem hiding this comment.
Actually, it has been merged, but not made it into a release.
While we're developing this, it makes sense to get the latest version on main for the canonical-sphinx extension.
Updated.
Make sure the GitHub folder is also updated when initialising. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
The default is to show contributors, but this can be turned off. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
ru-fu
force-pushed
the
DOCPR-519-contributors
branch
from
956485b
to
13f2014
Compare
We should use the latest release in the end - but for now, using the latest (untagged) version will speed up development. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
ru-fu
merged commit 25c5444
into
canonical:use-canonical-sphinx-extension
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the updated canonical-sphinx-extensions (canonical/canonical-sphinx-extensions#41) and the updated canonical-sphinx package (canonical/canonical-sphinx#25).