Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor woke for SSoT #70

Merged
merged 1 commit into from
Aug 15, 2023
Merged

feat: refactor woke for SSoT #70

merged 1 commit into from
Aug 15, 2023

Conversation

lblythen
Copy link
Contributor

@lblythen lblythen commented Aug 13, 2023

  • Replace woke command in GitHub action with call to existing make woke
  • Makefile needs sudo to install Snap if woke missing
  • Missing-woke problem solved by sudo snap install; no need for error exit
  • Jira

- Replace woke command in GitHub action with call to existing make woke
- Makefile needs sudo to install Snap if woke missing
- Missing-woke problem solved by sudo snap install; no need for error
  exit
@lblythen lblythen requested a review from ru-fu August 14, 2023 08:48
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the sudo snap install will always work on the GitHub servers.
It did in this PR though - so I'm fine with getting this in and monitoring if it causes any problems.

@ru-fu ru-fu merged commit 329290d into canonical:main Aug 15, 2023
3 checks passed
@lblythen lblythen deleted the feature/refactor-woke-for-ssot branch September 14, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants