-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin sphinx version #76
Conversation
Seems the latest Sphinx update has caused some issues ... 7.2.2 doesn't work with the notfound extension (see readthedocs/sphinx-notfound-page#219 ). When restricting Sphinx to <7.2.0, RTD uses 6.2.1 though, which is incompatible with a Furo change (see pradyunsg/furo#693 ). Therefore, restrict Sphinx to 7.1.2 until the issues are resolved. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Closes canonical#74. Signed-off-by: Ruth Fuchss <ruth.fuchss@canonical.com>
Hello, pinning This version of that dependency seems to work: |
Do you have a link to your build? |
I am not sure if it is publicly visible, this is the link: https://readthedocs.com/projects/canonical-checkbox/builds/1668863/ Reproducing offline the steps but pinning the Sphinx version breaks the process when installing requirements.txt (due to an incompatibility between the two modules) |
I can't claim that I really understand what RTD is doing - but in your build, RTD actually uses Sphinx 6.2.1. From your log:
My guess is that this is because of the compatibility issue you mention. First, the general requirements are installed, and RTD picks 6.2.1 as the latest version that is compatible. Pinning Sphinx to 7.1.2 in the project requirements won't make a difference for the general requirements, but it forces 7.1.2 to be installed afterwards, and that's why the build works. |
Oh, and I just saw that the installation for the starter pack also gives this error:
But this doesn't matter since we're using furo and not sphinx-rtd-theme. |
@ru-fu Seems the issue was promptly resolved:
|
The Furo part of the issue was resolved. The |
This should fix the RTD build error.