Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conventional commits #125

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conventional commits #125

merged 2 commits into from
Sep 5, 2023

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@sergiusens
docs: add conventional commits as part of the style
98b4966 
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@sergiusens
ci: check for conventional commits
8aa2a40 
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #125 (8aa2a40) into main (a913629) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
  Branches         2         2           
=========================================
  Hits            10        10

lengau
lengau approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@lengau lengau self-requested a review August 24, 2023 23:45
mr-cal
mr-cal approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm a big fan of conventional commits!

@sergiusens sergiusens merged commit fe1f9b0 into main Sep 5, 2023
12 checks passed
@sergiusens sergiusens deleted the conventional-commits branch September 5, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiusens @lengau @mr-cal