Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventional commits #125

Merged
merged 2 commits into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: conventional commits
uses: webiny/action-conventional-commits@v1.1.0
sergiusens marked this conversation as resolved.
Show resolved Hide resolved
- name: Setup Python
uses: actions/setup-python@v4
with:
Expand Down
28 changes: 28 additions & 0 deletions HACKING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,33 @@ You can also see all the environments by simply running ``tox list``
Running ``tox run -m format`` and ``tox run -m lint`` before committing code is
recommended.

Code Style
==========

Commits
#######

Format your commits following the conventional_ commit style.

Optionally, use the parens to scope to a particular component where
applicable.

See below for some examples of commit headings::

feat: inherit context from services
test: increase unit test stability
fix: check foo before running bar
feat(daemon): foo the bar correctly in the baz
test(daemon): ensure the foo bars correctly in the baz
fix(test): mock class Foo
ci(snap): upload the snap artefacts to Github
chore(deps): update go.mod dependencies


Recommended prefixes are: ``fix:``, ``feat:``, ``build:``, ``chore:``, ``ci:``,
``docs:``, ``style:``, ``refactor:``, ``perf:`` and ``test:``


.. _Black: https://black.readthedocs.io
.. _`Canonical contributor licence agreement`: http://www.ubuntu.com/legal/contributors/
.. _deadsnakes: https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa
Expand All @@ -97,3 +124,4 @@ recommended.
.. _ruff: https://github.com/charliermarsh/ruff
.. _ShellCheck: https://www.shellcheck.net/
.. _tox: https://tox.wiki
.. _conventional: https://www.conventionalcommits.org/en/v1.0.0/#summary