Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: starbase breakage from #265 #270

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: starbase breakage from #265 #270

merged 3 commits into from
Oct 11, 2024

Conversation

mattculler
Copy link
Contributor

@mattculler mattculler commented Oct 11, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Somehow a few little issues slipped through the healthy reviewage in #265

@mattculler mattculler requested review from lengau and a team October 11, 2024 20:43
lengau
lengau reviewed Oct 11, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lengau lengau requested a review from a team October 11, 2024 20:44
@mattculler @lengau
Update Makefile
514d79f 
Co-authored-by: Alex Lowe <alex.lowe@canonical.com>
@mattculler mattculler merged commit 9027b2c into main Oct 11, 2024
2 of 3 checks passed
@mattculler mattculler deleted the work/missed-sb branch October 11, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@lengau lengau lengau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattculler @tigarmo @lengau