Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: starbase breakage from #265 #270

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: starbase breakage from #265 #270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9cef88
fix: broken shell escaping
mattculler Oct 11, 2024
699191e
fix: improper shell escaping and missed alias
mattculler Oct 11, 2024
514d79f
Update Makefile
mattculler Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ help: ## Show this help.
setup: ## Set up a development environment
ifeq ($(OS),Linux)
changes="`sudo snap install --no-wait codespell`"
changes="${changes} `sudo snap install --no-wait ruff`"
changes="${changes} `sudo snap install --no-wait shellcheck`"
changes="${changes} `sudo snap install --classic --no-wait astral-uv`"
for change in ${changes}; do
snap watch ${change}
changes="$$changes `sudo snap install --no-wait ruff`"
changes="$$changes `sudo snap install --no-wait shellcheck`"
changes="$$changes `sudo snap install --classic --no-wait astral-uv`"
for change in $$changes; do
snap watch $$change
done
else ifeq ($(OS),Windows_NT)
pipx install uv
Expand All @@ -66,21 +66,24 @@ endif

---------------- : ## ----------------

.PHONY: autoformat
autoformat: format-ruff format-codespell ## Run all automatic formatters
.PHONY: format
format: format-ruff format-codespell ## Run all automatic formatters

.PHONY: format-ruff
format-ruff: ##- Automatically format with ruff
ruff check --fix $(SOURCES)
success=true
ruff check --fix $(SOURCES) || success=false
ruff format $(SOURCES)
$success || exit 1
$$success || exit 1

.PHONY: format-codespell
format-codespell: ##- Fix spelling issues with codespell
uv run codespell --toml pyproject.toml --write-changes $(SOURCES)

.PHONY: autoformat
autoformat: format # Alias for 'format'

---------------- : ## ----------------

.PHONY: lint
Expand Down
Loading