Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update created & maintain by section #100

Merged
merged 6 commits into from
Sep 18, 2024
Merged

Update created & maintain by section #100

merged 6 commits into from
Sep 18, 2024

Conversation

cp-mayank
Copy link
Collaborator

@cp-mayank cp-mayank commented Sep 18, 2024

Summary by CodeRabbit

  • Documentation
    • Renamed the "Created & Maintained By" section to "Credits" for improved clarity.
    • Added a new "Feedback and Suggestions" section for user input and bug reporting.
    • Updated the image source for the call-to-action button to enhance accessibility.
    • Included links to the Canopas team's website and Twitter for better communication.

Copy link

coderabbitai bot commented Sep 18, 2024

Walkthrough

The changes made in the pull request focus on updating the README.md file for the Khelo project. The "Created & Maintained By" section has been renamed to "Credits," retaining acknowledgment of the Canopas team and adding links to their website and Twitter. A new section titled "Feedback & Suggestions" has been introduced, directing users to the GitHub Issues page. Additionally, the image source for a call-to-action button has been updated to reflect a new file path.

Changes

File Change Summary
README.md Renamed section from "Created & Maintained By" to "Credits"; added "Feedback & Suggestions" section; updated image source for call-to-action button.

Suggested reviewers

  • cp-sidhdhi-p

Poem

In the meadow where the code does play,
A rabbit hops, and changes sway.
"Credits" now shines, clear and bright,
With links to follow, what a delight!
The button's path has found its way,
Hooray for updates, hip-hip-hooray! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cp-mayank cp-mayank marked this pull request as ready for review September 18, 2024 09:17
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 45e5639 and c872029.

Files ignored due to path filters (1)
  • screenshots/cta_btn.png is excluded by !**/*.png
Files selected for processing (1)
  • README.md (1 hunks)
Additional context used
Markdownlint
README.md

62-62: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Additional comments not posted (1)
README.md (1)

59-60: LGTM!

The changes to the section title and content improve clarity and conciseness while maintaining the acknowledgment of the Canopas team.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
README.md (1)

59-62: Excellent addition of the "Feedback and Suggestions" section!

The new section provides clear guidance on where to report issues and have discussions. The GitHub Issues link is correctly formatted.

To improve readability, consider adding a comma after "For bugs" as suggested by the static analysis tool:

-For bugs, questions and discussions please use
+For bugs, questions, and discussions, please use
Tools
LanguageTool

[typographical] ~61-~61: Consider adding a comma here.
Context: ...ons For bugs, questions and discussions please use the [Github Issues](https://github....

(PLEASE_COMMA)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c872029 and bc56844.

Files selected for processing (1)
  • README.md (1 hunks)
Additional context used
LanguageTool
README.md

[typographical] ~61-~61: Consider adding a comma here.
Context: ...ons For bugs, questions and discussions please use the [Github Issues](https://github....

(PLEASE_COMMA)

Markdownlint
README.md

68-68: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Additional comments not posted (2)
README.md (2)

65-66: LGTM!

The new "Credits" section provides clear attribution to the Canopas team for their ownership and maintenance of the project. The Canopas website link and Twitter handle are correctly formatted.


68-68: Verify the image source update.

Please ensure that the call-to-action button image file has been moved from ./cta/cta_btn.png to ./screenshots/cta_btn.png. If not, please update the image source accordingly.

Add alternate text for the image.

As mentioned in the previous review comment and flagged by the static analysis tool, please add alternate text (alt text) for the image to improve accessibility.

Apply this diff to add alternate text:

-<a href="https://canopas.com/contact"><img src="./screenshots/cta_btn.png" width=300></a>
+<a href="https://canopas.com/contact"><img src="./screenshots/cta_btn.png" alt="Contact Canopas" width=300></a>
Tools
Markdownlint

68-68: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
README.md (1)

68-68: Consider removing the excessive exclamation marks.

The use of 4 exclamation marks at the end of the segment might seem excessive and unprofessional. Please consider removing them to maintain a more professional tone.

Apply this diff to remove the excessive exclamation marks:

-You can follow them on Twitter at [@canopassoftware](https://twitter.com/canopassoftware) for project updates and releases. If you are interested in building apps or designing products, please let us know. We'd love to hear from you!!!!
+You can follow them on Twitter at [@canopassoftware](https://twitter.com/canopassoftware) for project updates and releases. If you are interested in building apps or designing products, please let us know. We'd love to hear from you!
Tools
LanguageTool

[style] ~68-~68: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 2377 characters long)
Context: ... let us know. We'd love to hear from you! ...

(EN_EXCESSIVE_EXCLAMATION)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bc56844 and 93355da.

Files selected for processing (1)
  • README.md (1 hunks)
Additional context used
LanguageTool
README.md

[style] ~68-~68: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 2377 characters long)
Context: ... let us know. We'd love to hear from you! ...

(EN_EXCESSIVE_EXCLAMATION)

Markdownlint
README.md

70-70: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

Additional comments not posted (3)
README.md (3)

59-62: LGTM!

The addition of a dedicated section for feedback and suggestions is a great way to encourage user engagement and improve the project based on user input. Linking to the GitHub Issues page is an effective approach to streamline the feedback process and keep all discussions in one place.


64-68: LGTM!

The new "Credits" section is a great addition to acknowledge the Canopas team's efforts and contributions to the Khelo project. Including a link to the Canopas website provides users with additional information about the team behind the project.

Tools
LanguageTool

[style] ~68-~68: Using many exclamation marks might seem excessive (in this case: 4 exclamation marks for a text that’s 2377 characters long)
Context: ... let us know. We'd love to hear from you! ...

(EN_EXCESSIVE_EXCLAMATION)


70-70: Address the accessibility issue by adding alternate text for the image.

The updated image source looks good. However, as mentioned in the previous review comment, please consider adding alternate text (alt text) for the image to improve accessibility.

Apply this diff to add alternate text:

-<a href="https://canopas.com/contact"><img src="./screenshots/cta_btn.png" width=300></a>
+<a href="https://canopas.com/contact"><img src="./screenshots/cta_btn.png" alt="Contact Canopas" width=300></a>
Tools
Markdownlint

70-70: null
Images should have alternate text (alt text)

(MD045, no-alt-text)

@canopas canopas deleted a comment from coderabbitai bot Sep 18, 2024
README.md Outdated Show resolved Hide resolved
@cp-mayank cp-mayank merged commit 5ce9e07 into main Sep 18, 2024
1 check passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
README.md (1)

61-64: Improve readability by adding a comma.

The content of the "Feedback & Suggestions" section is well-written and effectively directs users to the appropriate channels for reporting bugs and engaging in discussions.

To enhance readability, consider adding a comma after "For bugs" as suggested by the static analysis tool.

Apply this diff to add the comma:

-For bugs, questions and discussions please use the [Github Issues](https://github.com/canopas/khelo/issues).
+For bugs, questions, and discussions, please use the [Github Issues](https://github.com/canopas/khelo/issues).
Tools
LanguageTool

[typographical] ~63-~63: Consider adding a comma here.
Context: ...nt. For bugs, questions and discussions please use the [Github Issues](https://github....

(PLEASE_COMMA)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 93355da and 8d4ee4e.

Files ignored due to path filters (1)
  • cta/cta_btn.png is excluded by !**/*.png
Files selected for processing (1)
  • README.md (1 hunks)
Additional context used
LanguageTool
README.md

[typographical] ~63-~63: Consider adding a comma here.
Context: ...nt. For bugs, questions and discussions please use the [Github Issues](https://github....

(PLEASE_COMMA)

Additional comments not posted (3)
README.md (3)

59-59: LGTM!

The addition of the "Feedback & Suggestions" section is a great way to encourage user engagement and gather valuable insights for improving the project.


66-69: LGTM!

The renaming of the section to "Credits" and the inclusion of the Canopas team's acknowledgment, website link, and Twitter handle for project updates is a great way to give credit to the project maintainers and provide users with relevant resources.


69-69: Move the call-to-action button image back to the cta folder.

The change in the image source path indicates that the call-to-action button image has been moved from the cta folder to the screenshots folder. However, this contradicts the suggestion made in the past review comment by cp-sidhdhi-p, which recommends adding the button to the cta folder instead of the screenshots folder.

To maintain a more organized and logical structure, consider moving the button image back to the cta folder, as it is a call-to-action asset rather than a screenshot.

Apply this diff to revert the image source path:

-<a href="https://canopas.com/contact"><img src="./screenshots/cta_btn.png" width=300></a>
+<a href="https://canopas.com/contact"><img src="./cta/cta_btn.png" width=300></a>

@cp-mayank cp-mayank deleted the Mayank/update-readme branch September 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants