-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mainwin: Add support for shift+dblClick to insert syllable or chord #204
Conversation
40311d9
to
f333515
Compare
f333515
to
46322c6
Compare
CAFiguredBassMark *newElt = new CAFiguredBassMark(this, timeStart, 1); | ||
int i; | ||
for (i = 0; i < _figuredBassMarkList.size() && _figuredBassMarkList[i]->timeStart() < timeStart; i++) | ||
; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and this is old code, but was / is there a plan to add more code?
Else for loop could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the for loop here is to compute the value of i
(it's declared outside of the for block), because we have no more intelligent way of computing the position than linearly scanning the list. We could do binary search in the future though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addedd one comment about old code, that could be optimized.
We should make use of Unit Test generation features from github. |
Part of #84:
repositionElements
which is now virutal inCAContext
addEmptyElement
which is now virtual inCAContext
clickTimerActivated()
toCAScoreView
so we can read whether mouse press can be part of doubleclick or tripleclick before doing any other actions in mainwin