Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIDAPP-303]: Extend the model for knowledge base categories to have a slug value #276

Merged
merged 6 commits into from
Oct 14, 2024
Merged

[AIDAPP-303]: Extend the model for knowledge base categories to have a slug value #276

merged 6 commits into from
Oct 14, 2024

Conversation

payal-canyon
Copy link
Contributor

Ticket(s) or GitHub Issue

Technical Description

In the Knowledge Base Category, Added a Slug field with validation for unique, hyphenated, alphanumeric values only on create, edit, and view pages.

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

Yes. "KnowledgeBaseCategorySlug".

Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

@payal-canyon payal-canyon added the Change Type | New Feature New feature or request label Oct 10, 2024
@payal-canyon payal-canyon requested a review from a team as a code owner October 10, 2024 14:48
Orrison
Orrison requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a couple of small nits.

.config/psysh/psysh_history Outdated Show resolved Hide resolved
...e/tests/KnowledgeBaseCategory/RequestFactories/CreateKnowledgeBaseCategoryRequestFactory.php Outdated Show resolved Hide resolved
@Orrison Orrison added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit db531ea Oct 14, 2024
5 checks passed
@Orrison Orrison deleted the features/AIDAPP-303 branch October 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Orrison Orrison Orrison approved these changes

Assignees
No one assigned
Labels
Change Type | New Feature New feature or request Feature Flag Added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@payal-canyon @Orrison @joelicatajr