Skip to content

Commit

Permalink
fixes #1
Browse files Browse the repository at this point in the history
also unrefing the setInterval to not
  • Loading branch information
capaj committed Aug 31, 2016
1 parent 7b3f78d commit 016f19c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ const middlewareWrapper = (app, config) => {
config.spans.forEach((span) => {
span.os = []
span.responses = []
setInterval(() => gatherOsMetrics(io, span), span.interval * 1000)
const interval = setInterval(() => gatherOsMetrics(io, span), span.interval * 1000)
interval.unref()
})
// console.log(config)

Expand Down
8 changes: 5 additions & 3 deletions koa-monitor-frontend.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,11 @@ socket.on('stats', function (data) {
responseTimeChart.data.labels.push(data.responses.timestamp)

var deltaTime = data.responses.timestamp - rpsChart.data.labels[rpsChart.data.labels.length - 1]
rpsStat.textContent = (data.responses.count / deltaTime * 1000).toFixed(2)
rpsChart.data.datasets[0].data.push(data.responses.count / deltaTime * 1000)
rpsChart.data.labels.push(data.responses.timestamp)
if (deltaTime > 0) {
rpsStat.textContent = (data.responses.count / deltaTime * 1000).toFixed(2)
rpsChart.data.datasets[0].data.push(data.responses.count / deltaTime * 1000)
rpsChart.data.labels.push(data.responses.timestamp)
}

charts.forEach(function (chart) {
if (spans[defaultSpan].retention < chart.data.labels.length) {
Expand Down
11 changes: 7 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "koa-monitor",
"version": "0.2.3",
"version": "0.2.4",
"description": "Realtime monitoring for koa-based Node applications",
"main": "index.js",
"keywords": [
Expand All @@ -10,6 +10,9 @@
"koa",
"charts"
],
"engines" : {
"node" : ">=4"
},
"author": "Jiri Spac capajj@gmail.com",
"license": "MIT",
"repository": {
Expand All @@ -19,11 +22,11 @@
"dependencies": {
"handlebars": "^4.0.5",
"mz": "^2.4.0",
"pidusage": "^1.0.4",
"pidusage": "^1.0.5",
"socket.io": "^1.4.8"
},
"devDependencies": {
"koa": "^1.2.1",
"standard": "^8.0.0-beta.5"
"koa": "^1.2.2",
"standard": "^8.0.0"
}
}

0 comments on commit 016f19c

Please sign in to comment.