Skip to content

Commit

Permalink
Merge pull request #4 from cape-ph/semantic_release_fixes
Browse files Browse the repository at this point in the history
fix(semantic_release): remove incorrect use of `package-name` parameter
  • Loading branch information
mehalter committed Sep 18, 2024
2 parents 25fc9c8 + 05a7673 commit 3ea4e6c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ jobs:
uses: cape-ph/.github/.github/workflows/semantic_release.yml@main
secrets: inherit
with:
name: "CAPE Org Utilities"
is_production: ${{ github.event_name == 'push' }}
7 changes: 1 addition & 6 deletions .github/workflows/semantic_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ on:
default: false
required: false
type: boolean
name:
description: "Name of the package"
required: true
type: string

jobs:
conventional_commit:
Expand Down Expand Up @@ -46,12 +42,11 @@ jobs:
if: ${{ inputs.is_production }}
runs-on: ubuntu-latest
steps:
- uses: google-github-actions/release-please-action@v4
- uses: googleapis/release-please-action@v4
id: release
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: simple
package-name: ${{ inputs.name }}
- uses: actions/checkout@v4
- uses: rickstaa/action-create-tag@v1
if: ${{ steps.release.outputs.release_created }}
Expand Down
1 change: 0 additions & 1 deletion workflow-templates/semantic_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ jobs:
uses: cape-ph/.github/.github/workflows/semantic_release.yml@v1
secrets: inherit
with:
name: "CAPE Org Utilities"
is_production: ${{ github.event_name == 'push' }}

0 comments on commit 3ea4e6c

Please sign in to comment.