Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: 3PH #533

Draft
wants to merge 53 commits into
base: main
Choose a base branch
from
Draft

WIP: 3PH #533

wants to merge 53 commits into from

Commits on Jun 23, 2023

  1. Merge branch 'snapshot-clienthook' into 3ph

    @zenhack
    zenhack committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    c7568bb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. WIP: emit a senderPromise for third party caps 

    ...and some logic to start the handoff process. Not done yet, but only
affects codepaths where the network is non-nil.
    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    a18cfe6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'generic-idgen' into 3ph

    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    00016f7 View commit details
    Browse the repository at this point in the history

  3. Drop unnecessary cast.

    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    487a0bc View commit details
    Browse the repository at this point in the history

  4. Fill in question ID on provide.

    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    9b95244 View commit details
    Browse the repository at this point in the history

  5. More work on sending the provide message.

    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    9d21dc8 View commit details
    Browse the repository at this point in the history

  6. First pass at some of the vine logic.

    @zenhack
    zenhack committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    e5273b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2023

  1. Allocate provide ids from srcConn 

    i.e. the connection we're sending to.
    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    bcffd64 View commit details
    Browse the repository at this point in the history

  2. Start fleshing out data structures for 3PH.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    7e8c3ca View commit details
    Browse the repository at this point in the history

  3. First pass at handling disembargo with context.accept.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    0687477 View commit details
    Browse the repository at this point in the history

  4. Shut down the vine if sending resolve fails.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    f55caaf View commit details
    Browse the repository at this point in the history

  5. package testnetwork: export concrete type 

    I want to add a few testing-specific methods.
    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    1b5266a View commit details
    Browse the repository at this point in the history

  6. DRY up some of the test network implementation.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    b5411a9 View commit details
    Browse the repository at this point in the history

  7. test network: use the mutex package.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    06654da View commit details
    Browse the repository at this point in the history

  8. TestNetwork: add a DialTransport method.

    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    46cba7c View commit details
    Browse the repository at this point in the history

  9. Rework some bits of the Network interface. 

    In particular:

- The way we were supplying rpc.Options was clumsy. For now we have a
  network-specific way of doing this, but it could easily generalize.
- The Accept method wasn't really what we wanted either; has been
  replaced by Serve().
    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    63b6cf5 View commit details
    Browse the repository at this point in the history

  10. Add basic test for testnetwork. 

    Also, supply a large buffer for connections.
    @zenhack
    zenhack committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    1fba9f0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Test network: make implementation a pointer. 

    These need to be comparable.
    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a1349f3 View commit details
    Browse the repository at this point in the history

  2. Document that Networks must be comparable.

    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ddf4c10 View commit details
    Browse the repository at this point in the history

  3. Start working on a test for 3PH

    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    eef25d0 View commit details
    Browse the repository at this point in the history

  4. Fix out of bounds slice access

    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    9a2b2b8 View commit details
    Browse the repository at this point in the history

  5. Remove a TODO 

    I don't think there's more to do in this section.
    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    9461c10 View commit details
    Browse the repository at this point in the history

  6. Clean up the vine properly if sending fails.

    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4264f84 View commit details
    Browse the repository at this point in the history

  7. TestSendProvide: set an error reporter

    @zenhack
    zenhack committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    67b1a62 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Fix Client leak in send3PHPromise

    @zenhack
    zenhack committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    38c547c View commit details
    Browse the repository at this point in the history

  2. 3ph tests: check for call w/ promise and resolution.

    @zenhack
    zenhack committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    502cce5 View commit details
    Browse the repository at this point in the history

  3. Add a couple more 3PH checks 

    ...and note some other things to test.
    @zenhack
    zenhack committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b3e9fcb View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Finish out TestSendProvide

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    8e8efcc View commit details
    Browse the repository at this point in the history

  2. Stub out vine tests & factor out doBootstrap()

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    0651043 View commit details
    Browse the repository at this point in the history

  3. Implement TestVineUseCancelsHandoff 

    Fails currently; the exception returned is 'failed' rather than
'unimplemented', which suggests that it may not be being forwarded
correctly. Need to investigate further.

This also factors out a bunch of common logic into a helper function.
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    68465af View commit details
    Browse the repository at this point in the history

  4. Add missing messagetarget to call

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    8a1e2f1 View commit details
    Browse the repository at this point in the history

  5. Finish vine implementation. 

    This gets rid of a panic("TODO: ...").

The test still fails, but I know why.
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    601d9b9 View commit details
    Browse the repository at this point in the history

  6. Get vine test working.

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    fbbf0f4 View commit details
    Browse the repository at this point in the history

  7. Add some comments to tests

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f524899 View commit details
    Browse the repository at this point in the history

  8. Implement other vine test. 

    Passes!
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    a71bc43 View commit details
    Browse the repository at this point in the history

  9. 3PH: correctly handle sending resolves for dropped promises. 

    That is, don't, and clean up.

For good measure, move the snapshot.Release() out of the critical
section, as I'm not sure this is valid.
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    837cb16 View commit details
    Browse the repository at this point in the history

  10. AcceptIntroduced: SHOULD -> MUST

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    dbe07b0 View commit details
    Browse the repository at this point in the history

  11. Fix build errors 

    ...did I really not run the tests after this?
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    6816d38 View commit details
    Browse the repository at this point in the history

  12. Add a test for 3ph disembargos, and fix some issues. 

    Still fails because of the obvious panic("TODO..."), but caught a couple
unrelated bugs.
    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    24b569a View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/main' into 3ph

    @zenhack
    zenhack committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    eeed744 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Merge branch 'releaseExport-dq' into 3ph

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b8654f0 View commit details
    Browse the repository at this point in the history

  2. Fix bitrot re: releaseExport signature

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    81901e0 View commit details
    Browse the repository at this point in the history

  3. Fill in message target in provide disembargo.

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e18f75c View commit details
    Browse the repository at this point in the history

  4. Fix 3ph disembargo test

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    43c0722 View commit details
    Browse the repository at this point in the history

  5. Replace ErrorReporter with a structured logging interface. 

    The new interface:

- Has levels (debug, info, warn, error)
- Accepts arguments for structured logging

Per the comments, the interface is designed to be used with
*slog.Logger, though other implementations are possible (and we already
use one in test).
    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    1067d0e View commit details
    Browse the repository at this point in the history

  6. errReporter: no-op if Logger is nil.

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9e8acf5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'logger-interface' into 3ph

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    3adf1db View commit details
    Browse the repository at this point in the history

  8. Fix bitrot: ErrorReporter -> Logger

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    6cf0e01 View commit details
    Browse the repository at this point in the history

  9. 3ph: warn on failed introduction.

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    b2c7b80 View commit details
    Browse the repository at this point in the history

  10. Futureproof comment. 

    I'm going to punt this off until after the basic 3PH, so let's make sure
this is correct after that.
    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    d934815 View commit details
    Browse the repository at this point in the history

  11. Partially handle third party disembargos

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    24e8008 View commit details
    Browse the repository at this point in the history

  12. replace redundant logic with parsedMessageTarget.Encode

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    abc5258 View commit details
    Browse the repository at this point in the history

  13. send accept disembargos when necessary

    @zenhack
    zenhack committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    3d9ba97 View commit details
    Browse the repository at this point in the history