Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error on go1.23rc1 #576

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix build error on go1.23rc1 #576

merged 1 commit into from
Jul 19, 2024

Conversation

saschagrunert
Copy link
Contributor

Can be tested with:

podman run -v $PWD:/w -w /w -it fedora:rawhide bash -c "dnf install -y go git && go build ./..."

Fixes #575

@saschagrunert
Fix build error on go1.23rc1
ff2fd98 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert mentioned this pull request Jul 9, 2024
Merged
@kwilczynski
Copy link

Looks good! Thank you for a swift fix!

/approve
/lgtm

@kwilczynski kwilczynski mentioned this pull request Jul 11, 2024
Merged
lthibault
lthibault approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@lthibault lthibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, nice catch!

Apologies for taking so long to review. I am slowly spinning back up on capnp, so expecting to be more responsive going forward.

Thanks for submitting this!

@lthibault lthibault merged commit 4ed3db2 into capnproto:main Jul 19, 2024
0 of 4 checks passed
@kwilczynski
Copy link

@lthibault, thank you!

It would be great to get a new release with this fix. Do you have some plans around that? We would be much obliged.

@lthibault
Copy link
Collaborator

@kwilczynski My pleasure! Here is release v3.0.1-alpha.2

@kwilczynski kwilczynski mentioned this pull request Jul 21, 2024
Merged
@saschagrunert saschagrunert deleted the build-err-go1.23 branch July 22, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lthibault lthibault lthibault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error: invalid composite literal type T on go1.23rc1
3 participants
@saschagrunert @kwilczynski @lthibault