transport: Fix double release instances of {in,out}goingMsg #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matheusd
commented
Aug 13, 2024
matheusd
commented
- transport: Prove double release is occurring
- transport: Fix double release of incoming message
- transport: Track outoingMsg release status
This adds a panic on attempts to double release of a message. This might bubble up to a double release of an Arena, which is a misuse of the Arena contract. Adding this panic causes some tests to fail. This will be fixed in a future commit.
This fixes the double release panic introduced in the prior commit. The panic was only introduced to prove that double release is possible happening. Note: In my (matheusd) opinion, Release() calls should panic or error in case of double release so that callers are fixed and they themselves do not rely on this protection. This is suggested as a future change because it potentially breaks clients that were relying on this protection.
This was not correctly tracked.
lthibault
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.