perf(floating-menu): reduce forced synchronous layout (#79)

carbon-design-system · Jul 7, 2017 · dcdc8ec · dcdc8ec · chrisdhanaraj · Jul 7, 2017
1 parent bb1a90d
commit dcdc8ec
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/components/OverflowMenu.js b/components/OverflowMenu.js
@@ -45,7 +45,9 @@ class OverflowMenu extends Component {
   };
 
   componentDidMount() {
-    this.getMenuPosition();
+    requestAnimationFrame(() => {
+      this.getMenuPosition();
+    });
     this.hResize = OptimizedResize.add(() => {
       this.getMenuPosition();
     });

diff --git a/components/Tooltip.js b/components/Tooltip.js
@@ -29,7 +29,9 @@ class Tooltip extends Component {
   };
 
   componentDidMount() {
-    this.getTriggerPosition();
+    requestAnimationFrame(() => {
+      this.getTriggerPosition();
+    });
   }
 
   getTriggerPosition = () => {

diff --git a/package.json b/package.json
@@ -137,7 +137,10 @@
     "coverageDirectory": "./coverage",
     "moduleNameMapper": {
       "^.+\\.(scss)$": "<rootDir>/lib/styleMock.js"
-    }
+    },
+    "setupFiles": [
+      "<rootDir>/setup-jest.js"
+    ]
   },
   "lint-staged": {
     "*.js": [

diff --git a/setup-jest.js b/setup-jest.js
@@ -0,0 +1 @@
+window.requestAnimationFrame = (callback) => { callback(); };
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		window.requestAnimationFrame = (callback) => { callback(); };