feat(card group): adding left and right gutters to the cards when in … #12190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-amorim
requested review from
marcelojcs and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Valentin-Sorin-Nicolae
approved these changes
Jan 22, 2025
bruno-amorim
added
the
Ready to merge
marcelojcs
merged commit 06a9612
into
carbon-design-system:feature/gutters
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mobile
Related Ticket(s)
Closes #ADCMS-6599
Description
Adding left and right gutters to the Block Card Container component, specifically, so we make sure it's clear that cards are tappable and that they are indeed cards rather than background containers.
All card groups that are wrapped by
c4d-card-groupwill also be benefited from this update.Changelog
16pxinline margin added to the c4d-card-group element when in mobile.