Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve access checking code #4317

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Improve access checking code #4317

merged 4 commits into from
Sep 17, 2024

Conversation

brymer-meneses
Copy link
Contributor

@brymer-meneses brymer-meneses commented Sep 15, 2024 •
edited
Loading

This change accomplishes the TODOs for access checking. More specifically it,

  • makes SemIR::AccessKind formattable using llvm::formatv.
  • makes use of LookupUnqualifiedName to find Self.

jonmeow
jonmeow reviewed Sep 16, 2024
View reviewed changes
toolchain/sem_ir/name_scope.h Outdated Show resolved Hide resolved
toolchain/check/context.cpp Outdated Show resolved Hide resolved
toolchain/check/testdata/class/access_modifers.carbon Outdated Show resolved Hide resolved
jonmeow
jonmeow approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

auto-merge was automatically disabled September 17, 2024 16:26

Head branch was pushed to by a user without write access

@brymer-meneses
Copy link
Contributor Author

Seems like this was failing because of some line changes, sorry about that.

@jonmeow
Copy link
Contributor

jonmeow commented Sep 17, 2024

No worries!

@jonmeow jonmeow added this pull request to the merge queue Sep 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 17, 2024
@brymer-meneses
Improve access checking code (#4317)
0643b81 
This change accomplishes the TODOs for access checking. More
specifically it,
- makes `SemIR::AccessKind` formattable using `llvm::formatv`.
- makes use of `LookupUnqualifiedName` to find `Self`.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@jonmeow jonmeow added this pull request to the merge queue Sep 17, 2024
Merged via the queue into carbon-language:trunk with commit da40c8b Sep 17, 2024
8 checks passed
@brymer-meneses brymer-meneses deleted the refactor-access-modifers branch September 17, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brymer-meneses @jonmeow