Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3290] Match delegation agda specs in the implementation #4475

Merged
merged 6 commits into from
Apr 4, 2024
Merged

[ADP-3290] Match delegation agda specs in the implementation #4475

merged 6 commits into from
Apr 4, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Feb 29, 2024 •
edited by HeinrichApfelmus
Loading

This pull request aligns the behavior of the Delegations data structure with a specification in Agda.

  • Add Transition datatype to the Model
  • Add missing Deregister value to the genDelta
  • Update the QC specs

ADP-3290

@paolino paolino self-assigned this Feb 29, 2024
@paolino paolino added the Conway PRs to prepare to the Conway bump label Feb 29, 2024
@paolino paolino force-pushed the paolino/ADP-3290/match-delegation-agda-sepcs branch from 9fe2dbd to b8bcc84 Compare February 29, 2024 09:54
@paolino paolino force-pushed the paolino/ADP-3290/match-delegation-agda-sepcs branch from b8bcc84 to 8a4a4a3 Compare February 29, 2024 10:05
@HeinrichApfelmus HeinrichApfelmus marked this pull request as ready for review March 21, 2024 15:17
HeinrichApfelmus
HeinrichApfelmus approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊

I have update the QuickCheck properties. If you could take a look at them again and convince yourself that they align with the specification, that would be swell.

@paolino paolino added this pull request to the merge queue Apr 4, 2024
Merged via the queue into master with commit df60978 Apr 4, 2024
4 checks passed
@paolino paolino deleted the paolino/ADP-3290/match-delegation-agda-sepcs branch April 4, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Conway PRs to prepare to the Conway bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus