[ADP-3344] Implement REST-like IO interface for Deposit Wallet
#4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
3 times, most recently
from
ae3a5b0
to
cbc4689
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
8 times, most recently
from
2825954
to
33aec0f
Compare
paweljakubas
reviewed
Sep 9, 2024
paweljakubas
reviewed
Sep 9, 2024
paweljakubas
reviewed
Sep 9, 2024
lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/IO/Resource.hs
Outdated
Show resolved
Hide resolved
paweljakubas
reviewed
Sep 9, 2024
paweljakubas
reviewed
Sep 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
This pull requests implements a REST-like `IO` interface for the Deposit Wallet. This interface corresponds more closely to an HTTP interface. Essentially, the main difference between `Cardano.Wallet.Deposit.IO` and `Cardano.Wallet.Deposit.REST` is that the latter postpones the need to initialize the wallet. Instead of working with a `WalletInstance`, the latter module now works with a `WalletResource`, which is roughly a `TVar (Maybe WalletInstance)`. This mutable variable starts with `Nothing` and the function `putWallet` can be used to initialize the wallet, putting a `Just` in the mutable variable. In turn, a module `Cardano.Wallet.Deposit.IO.Resource` implements a data type `Resource` that encapsulate the idea of `TVar (Maybe WalletInstance)` and is (reasonably) safe to use in a concurrent environment. ### Comments * Not implemented yet: `withWalletResource` inspects the database directory and loads a wallet if necessary. ### Issue Number ADP-3344
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
2 times, most recently
from
0b30e73
to
5f29dce
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
from
5f29dce
to
a3874e9
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
from
a3874e9
to
19cecf8
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks good to me as well, thank you! 👍 The error type |
paolino
force-pushed
the
HeinrichApfelmus/ADP-3344/interface-rest
branch
from
19cecf8
to
053d8b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests implements a REST-like
IOinterface for the Deposit Wallet. This interface corresponds more closely to an HTTP interface.Essentially, the main difference between
Cardano.Wallet.Deposit.IOandCardano.Wallet.Deposit.RESTis that the latter postpones the need to initialize the wallet. Instead of working with aWalletInstance, the latter module now works with aWalletResource, which is roughly aTVar (Maybe WalletInstance). This mutable variable starts withNothingand the functionputWalletcan be used to initialize the wallet, putting aJustin the mutable variable.In turn, a module
Cardano.Wallet.Deposit.IO.Resourceimplements a data typeResourcethat encapsulate the idea ofTVar (Maybe WalletInstance)and is (reasonably) safe to use in a concurrent environment.Comments
withWalletResourceinspects the database directory and loads a wallet if necessary.Issue Number
ADP-3344