[ADP-3344] Use Read.ChainPoint in Cardano.Wallet.Deposit.Read
#4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-chainpoint
branch
2 times, most recently
from
a1d853a
to
ccdf443
Compare
| mempty | ||
| & type_ ?~ OpenApiString | ||
| & format ?~ "hex" | ||
| & minLength ?~ (2*32) |
There was a problem hiding this comment.
what about introducing charsPerByte = 2 and internally bytePayload=32 Then it would be very clear and well documented imho;-)
There was a problem hiding this comment.
I have added a definition hexCharactersPerByte.
|
|
||
| genChainPoint :: Gen Read.ChainPoint | ||
| genChainPoint = frequency | ||
| [ ( 1, pure Read.GenesisPoint) -- "common" but not "very common" |
There was a problem hiding this comment.
so rarely common - 😄 ?
There was a problem hiding this comment.
I have removed the comment.
paweljakubas
approved these changes
Sep 13, 2024
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3344/deposit-chainpoint
branch
from
ccdf443
to
72186bb
Compare
HeinrichApfelmus
deleted the
HeinrichApfelmus/ADP-3344/deposit-chainpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
Cardano.Wallet.Deposit.Readto use theChainPointtype fromCardano.Wallet.Read.Comment
Cardano.Wallet.Deposit.Readis subsumed by the officialCardano.Wallet.Read.Issue Number
ADP-3344