Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3436] Add customer address query to UI #4780

Merged
merged 6 commits into from
Sep 23, 2024
Merged

[ADP-3436] Add customer address query to UI #4780

merged 6 commits into from
Sep 23, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 18, 2024 •
edited
Loading

  • Add a UI query form to get individual addresses for "customers"
  • Remove support for createAddress
  • Fix tests and scenarios using createAddress to use customerAddress and start the wallet with a big enough tracked customer numbers

ADP-3436

@paolino paolino self-assigned this Sep 18, 2024
@paolino paolino marked this pull request as draft September 18, 2024 16:44
@paolino paolino force-pushed the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch from 36a7625 to dc93546 Compare September 18, 2024 19:42
@paolino paolino marked this pull request as ready for review September 18, 2024 19:44
@paolino paolino force-pushed the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch 2 times, most recently from 27ac69d to 7559a82 Compare September 18, 2024 20:36
HeinrichApfelmus
HeinrichApfelmus approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 😊 Two requests relating to customerAddress, and toShortByteString.

lib/customer-deposit-wallet/src/Cardano/Wallet/Deposit/REST.hs Outdated Show resolved Hide resolved
lib/ui/src/Cardano/Wallet/UI/Lib/Address.hs Outdated Show resolved Hide resolved
lib/ui/src/Cardano/Wallet/UI/Lib/Address.hs Outdated Show resolved Hide resolved
lib/ui/src/Cardano/Wallet/UI/Lib/Address.hs Show resolved Hide resolved
lib/ui/cardano-wallet-ui.cabal Outdated Show resolved Hide resolved
Base automatically changed from paolino/ADP-3435/add-deposit-wallet-deletion-UI to master September 19, 2024 15:24
@paolino paolino added Deposit UI UI related changes labels Sep 20, 2024
@paolino paolino force-pushed the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch from 7559a82 to 759f73f Compare September 20, 2024 13:53
@paolino paolino force-pushed the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch 2 times, most recently from 15bfa81 to a4696c0 Compare September 20, 2024 15:22
@paolino paolino force-pushed the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch from a4696c0 to d265de6 Compare September 20, 2024 15:30
@paolino paolino added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 20, 2024
@paolino paolino merged commit d5afc6e into master Sep 23, 2024
22 checks passed
@paolino paolino deleted the paolino/ADP-3436/add-user-mgmt-UI-page-to-deposit-wallet branch September 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
Deposit UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus