Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3437] Use REST interface in data API to create the deposit wallet #4782

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[ADP-3437] Use REST interface in data API to create the deposit wallet #4782

wants to merge 14 commits into from

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Sep 19, 2024 •
edited
Loading

  • factor out a rest sublibrary in customer-deposit-wallet to hold common to UI REST code
  • add wallet creation endpoints to customer-depisit-wallet HTTP data API
  • add CLI options to control the deposit wallet data service
  • enable the deposit wallet in the wallet executable

ADP-3437

@paolino paolino self-assigned this Sep 19, 2024
@paolino paolino marked this pull request as ready for review September 19, 2024 14:34
@paolino paolino changed the title [ADP-3437] Use Rest interface in json api to create the deposit wallet [ADP-3437] Use REST interface in data API to create the deposit wallet Sep 19, 2024
Base automatically changed from paolino/ADP-3435/add-deposit-wallet-deletion-UI to master September 19, 2024 15:24
@paolino paolino force-pushed the paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet branch 2 times, most recently from eeabf43 to 89c0906 Compare September 20, 2024 15:53
@paolino paolino force-pushed the paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet branch from 70b13a8 to 1bdfcb9 Compare September 21, 2024 15:49
@paolino
Parametrise just build
eafd46b
@paolino
Factor out REST module in a separate sublibrary together with code fr…
d2ab4c3 
…om the ui to be reused in json http
@paolino
Add JSON instances for post wallet parameters
b7b24a0
@paolino
Remove unused HTTP module
33f7919
@paolino
Add wallet creation to json http api and use REST interface
781d496
@paolino
Use PutNocontent in put wallet endpoints
b3d061f
@paolino
Remove Endpoints module
606d1c3
@paolino
Rename CustomerAPI to API in deposit json api
b840005
@paolino
Rename Cardano.Wallet.Deposit.HTTP.Implementation in Cardano.Wallet.D…
a1697bf 
…eposit.HTTP.server
@paolino
Add a CLI option to control the presence of the deposit wallet json s…
79f5d6c 
…erice
@paolino
Add deposit wallet json api to the wallet application
2148ce6
@paolino
Rename walletPresent in walletPresence
dc170e3
@paolino
Add deposit port to run-wallet.hs
be66398
@paolino
Remove page handlers from deposit wallet UI
52c2666 
Now loading is taken care of outside the server, in Application module in the exe package
@paolino paolino force-pushed the paolino/ADP-3437/use-REST-interface-indata-API-for-deposit-wallet branch 2 times, most recently from 0743527 to 52c2666 Compare September 23, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus Awaiting requested review from HeinrichApfelmus

At least 1 approving review is required to merge this pull request.

Assignees

@paolino paolino

Labels
Deposit JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paolino