Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: web3 spring security #188

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Feature: web3 spring security #188

merged 4 commits into from
Sep 13, 2023

Conversation

matiwinnetou
Copy link
Contributor

@matiwinnetou matiwinnetou commented Sep 8, 2023

Changes:

  • instead of posting coseSignature and cosePublicKey as body one has to post this as:
X-CIP93-Signature
X-CIP93-Public-Key

headers.

some API requests, i.e. vote receipt and login have been changed from POST to GET

image

@matiwinnetou matiwinnetou changed the title Feature: web3 spring security. Feature: web3 spring security Sep 8, 2023
@matiwinnetou matiwinnetou force-pushed the web3-spring-security branch 6 times, most recently from 7ab3996 to 27c9531 Compare September 9, 2023 08:46
@matiwinnetou matiwinnetou marked this pull request as ready for review September 9, 2023 08:52
@matiwinnetou
Copy link
Contributor Author

@vetalcore @satran004 @jimcase

I would appreciate if you could make in the frontend apps appropriate changes to accomodate for these backwards incompatible changes.

Please make changes in this branch so we can merge this ASAP.

Copy link
Contributor

@nemo83 nemo83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimcase
Copy link
Contributor

jimcase commented Sep 11, 2023

FE changes supporting these headers here: feature/using-headers-for-body-request

@matiwinnetou matiwinnetou merged commit a81e735 into main Sep 13, 2023
7 of 8 checks passed
@matiwinnetou matiwinnetou deleted the web3-spring-security branch September 20, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants