feat(cip-1694): restyle intro page #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vetalcore
commented
Jul 19, 2023
•
vetalcore
commented
cfuisat
reviewed
Jul 20, 2023
ui/cip-1694/src/App.tsx
Outdated
| <Footer /> | ||
| <Toaster | ||
| toastOptions={{ | ||
| className: '', |
There was a problem hiding this comment.
of course use the class, i was in rush. and colours from theme. thanks.
| @@ -1,4 +1,3 @@ | |||
| export const USER_SESSION_KEY = 'userInSession'; | |||
| // TODO: do we nned to think about localizations? | |||
There was a problem hiding this comment.
will add in a separate pr if approved
| const time = new Date(); | ||
| const endTime = moment('09-01-2023', 'MM-DD-YYYY'); // summit date | ||
| time.setSeconds(time.getSeconds() + endTime.diff(time, 'seconds')); // time left for summit date | ||
| const endTime = moment('09-01-2023', 'MM-DD-YYYY').format('D MMMM YYYY, h:mm a'); // summit date |
There was a problem hiding this comment.
can we add this as env variable?
| })); | ||
|
|
||
| // TODO: could we rename this to be more a generic one? just "slides"? |
There was a problem hiding this comment.
then it goes into components/common
ui/cip-1694/src/pages/Vote/Vote.tsx
Outdated
| @@ -116,7 +116,7 @@ const Vote = () => { | |||
| votePower: votingPower, | |||
| }); | |||
| signMessage(canonicalVoteInput, async (signature, key) => { | |||
| // TODO: castAVoteWithDigitalSignature are incompatible with requestVoteObject | |||
| // FIXME: castAVoteWithDigitalSignature are incompatible with requestVoteObject | |||
There was a problem hiding this comment.
nvm, already resolved
|
Great work. looks awesome |
cfuisat
approved these changes
Jul 21, 2023
|
Just a note i am off for 2 weeks, this PR is good to merge just take care of failed e2e tests. Thanks |
vetalcore
force-pushed
the
feature/restyle-intro-page
branch
from
9522cd3
to
529c97e
Compare
vetalcore
force-pushed
the
feature/restyle-intro-page
branch
3 times, most recently
from
559364b
to
2f58f55
Compare
vetalcore
force-pushed
the
feature/restyle-intro-page
branch
from
2f58f55
to
0f66c2c
Compare
vetalcore
force-pushed
the
feature/restyle-intro-page
branch
from
6978744
to
2e696e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.