-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Do It With Lovelace to Showcase #1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 - the ecosystem
tag is inappropriate because this is only for projects which explore the Cardano ecosystem itself. You would have to choose at least one appropriate tag from the ones currently listed here (and next time please check the showcases.js
file to make sure the definition fits your project): https://developers.cardano.org/showcase
2 - As it also says in the JS file, // Add your project to (THE END OF) this list.
so please if continuing your submission then move your definition to the end of the array.
3 - In English usage the "little words" it
and with
are not capitalised even in titles.
If there isn't an appropriate category tag we might add a charity
category but I haven't seen another such project come along in the last several months, and we try to avoid categories with only 1 member. In any case I could agree with defining a charity
tag if other editors note here they are in favour.
Sorry @rphair, I was struggling with the tags. I didn't find any tag appropiate for my project. I was thinking in something like PD: The tag for projects which explore Cardano is 2 - Shame on me! sorry! I'll change it. 🙃 |
I commited the fixes. I broke the rule Thank you in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other reviewers: I think it would support a good space in our ecosystem if we could create a funding
tag (as OP suggests & I realise this is a more general case than charity
and a more contemporary term than fundraising
). If this is favourably reviewed then I'll create the tag in this PR so it builds properly.
@jmagan I believe the acceptance of this submission now is dependent upon creating that category: let's see what happens. In the meantime I also agree with what's posted on the forum (Do It With Lovelace: A Simple Platform for Donations on Cardano) and think you could improve this by responding to what I think would be common question / critique:
Donations to who or what? At the moment, it just looks like it’s using AdaPay’s form. No receive address to confirm receipt to organisation. No method to add new organisation except through email? Nice try. Really basic.
... and add a landing page on the web site rather than directing visitors just to the app
page itself which doesn't have anything in the way of online help, or even what happens in the app, or any information about your organisation except for the fluff on the "About" page.
I agree with the Forum that is has potential but I think we need to see the same calibre of detail and user support as we have for other items on the Showcase before including this on the Dev Portal.
Hi @rphair, thank you for your help. I've just replied in the cardano forum:
I'll be working to improve and meet all the requirements. 🙂 |
@rphair I'm happy to show you the brand new landing page 🙂 https://app.doitwithlovelace.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jmagan - the descriptive landing page is a good orientation. I think it all works well together now.
Other reviewers: like I said in #1043 (review), a vote for this PR is a vote for also creating the funding
tag which I have verified works well in a local build. ✔️
Last merge conflict resolution I had to remove a redundant entry for BALANCE showcase item from the end of the array. It's still in @jmagan's branch here (so the one I removed was redundant; an artefact from this PR's age): https://github.com/jmagan/developer-portal/blob/8db49a6118cad18cac094bea857069087560625a/src/data/showcases.js#L1065 @katomm @rdlrt @fill-the-fill etc. can we please merge this so we can have a |
about last commit (fdb0191), and why this PR affects that listing at all: A merge conflict from another PR created a second BALANCE entry visible now on the |
Checklist
yarn build
after adding my changes without getting any errors.Showcase addition
ecosystem