Registering a Pool: remove GitHub & TinyURL #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed Git as the recommended place for saving metadata and also removed any mention of tinyurl.
rdlrt
reviewed
Jul 1, 2023
Co-authored-by: RdLrT <3169068+rdlrt@users.noreply.github.com>
rdlrt
approved these changes
Jul 1, 2023
rphair
changed the title
rphair
approved these changes
Jul 1, 2023
fill-the-fill
approved these changes
Jul 3, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
yarn buildafter adding my changes without getting any errors.Updating documentation or Bugfix
I removed Git as the recommended place for saving metadata and also removed any mention of TinyURL. As @SmaugPool mentioned here, TinyURL uses Cloudflare with occasional CAPTCHA for human verification, making it unsuitable for requests from automated APIs.
coincashew/coincashew#179
I decided to drop GitHub too, because Git was never a good place for metadata (Git has a rate limiter, for example, which might cause issues), especially now when there is no way to shorten URLs.