Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lace wallet: tag as Open Source & link to repo #1118

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Lace wallet: tag as Open Source & link to repo #1118

merged 5 commits into from
Aug 1, 2023

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Jul 29, 2023

Fixes #1117 (cc @olgahryniuk)

@rphair rphair added the showcase Indicates a PR/issue on showcase label Jul 29, 2023
@rphair rphair mentioned this pull request Jul 29, 2023
Closed
rdlrt
rdlrt approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@rdlrt rdlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added a commit to remove yarn.lock - but not sure if it was intentional, so reverted back for now. @rphair - please check if applicable

@rphair
Copy link
Collaborator Author

rphair commented Jul 30, 2023 •
edited
Loading

thanks @rdlrt - no, I didn't notice the yarn.lock was there, and with this file gitignored the whole time I don't see why it would have been in my original commit. The only thing I can think of is that I recently built at least 1 PR locally... some old one(s) or maybe a new one had yarn.lock in its own branch (my chief suspect = #1111 (comment)). Still the best insight I can give people unfortunately is that "it happens every now and then" with a quick procedure for removing it from their PR. 🤔 (it's gone now)

@rphair rphair merged commit 8195149 into cardano-foundation:staging Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katomm katomm katomm approved these changes

@os11k os11k os11k approved these changes

@rdlrt rdlrt rdlrt approved these changes

@fill-the-fill fill-the-fill Awaiting requested review from fill-the-fill

Assignees
No one assigned
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag Lace wallet as open-source
4 participants
@rphair @rdlrt @os11k @katomm