-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Cardano Foundation Explorer and CExplorer to showcases #1300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kammerlo cexplorer.io
is already listed as a builder tool (/src/data/builder-tools.js
):
{
title: "Cexplorer",
description: "Rich featured blockchain explorer with support of all testnet instances and an API.",
preview: require("./builder-tools/cexplorer.png"),
website: "https://cexplorer.io",
getstarted: null,
tags: ["operatortool"],
},
We've had a long standing policy of only listing each tool once even if eligible for both portfolios. There are a few PRs you can see in the history of the times Adapools / Cexplorer has been added, removed, and modified. The discussion of which portfolio (Showcase or Builder Tools) was in the most recent PR the as I recall... I'll find & link to it again if any difficulty finding it.
@katomm do we still have the same policy? In my opinion some tools are so universally used that it makes sense for their 2 capacities to show in the 2 portfolios (in this case, both an operator tool and end-user analytics).
Great catch @rphair. I should have provided more context, but was on the phone when I reviewed this entry. I discussed this PR with @Kammerlo upfront and we both were looking for CExplorer is listed already in the explorer category (and were unable to find it) because we want to link from another page to all the explorers. I remember the back and forth with Adapools and CExplorer and want to make the proposal here to add CExplorer to showcase in the category "explorers" and remove it from Builder Tools. I understand they have APIs but it is still an explorer. (happy to make the pull request and sorry for the confusion) |
…is adding it to showcase
FYI: I have opened the PR to remove the cexplorer from builder tools. |
…is adding it to showcase
👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.
Checklist
yarn build
after adding my changes without getting any errors.Showcase addition
Title: Cardano Foundation Explorer
explorer
Title: CExplorer
explorer