Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cardano Foundation Explorer and CExplorer to showcases #1300

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

Kammerlo
Copy link
Member

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Please complete a Checklist
  2. Fill in all sections of the template
  3. Click "Create pull request"

Checklist

Showcase addition

Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kammerlo cexplorer.io is already listed as a builder tool (/src/data/builder-tools.js):

  {
    title: "Cexplorer",
    description: "Rich featured blockchain explorer with support of all testnet instances and an API.",
    preview: require("./builder-tools/cexplorer.png"),
    website: "https://cexplorer.io",
    getstarted: null,
    tags: ["operatortool"],
  },  

We've had a long standing policy of only listing each tool once even if eligible for both portfolios. There are a few PRs you can see in the history of the times Adapools / Cexplorer has been added, removed, and modified. The discussion of which portfolio (Showcase or Builder Tools) was in the most recent PR the as I recall... I'll find & link to it again if any difficulty finding it.

@katomm do we still have the same policy? In my opinion some tools are so universally used that it makes sense for their 2 capacities to show in the 2 portfolios (in this case, both an operator tool and end-user analytics).

@katomm
Copy link
Member

katomm commented Aug 13, 2024

Great catch @rphair. I should have provided more context, but was on the phone when I reviewed this entry. I discussed this PR with @Kammerlo upfront and we both were looking for CExplorer is listed already in the explorer category (and were unable to find it) because we want to link from another page to all the explorers.

I remember the back and forth with Adapools and CExplorer and want to make the proposal here to add CExplorer to showcase in the category "explorers" and remove it from Builder Tools. I understand they have APIs but it is still an explorer.

(happy to make the pull request and sorry for the confusion)

@katomm katomm added the showcase Indicates a PR/issue on showcase label Aug 13, 2024
katomm added a commit to adatainment/developer-portal that referenced this pull request Aug 15, 2024
@katomm
Copy link
Member

katomm commented Aug 15, 2024

FYI: I have opened the PR to remove the cexplorer from builder tools.

@katomm katomm merged commit d890cc9 into cardano-foundation:staging Aug 15, 2024
3 checks passed
katomm added a commit to adatainment/developer-portal that referenced this pull request Aug 28, 2024
katomm added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants