Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting governance actions: Use latest guardrails script #1311

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

CarlosLopezDeLara
Copy link
Collaborator

👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.

  1. Please complete a Checklist
  2. Fill in all sections of the template
  3. Click "Create pull request"

Checklist

<-- Please fill the boxes with [x] before submitting a pull request -->

Updating documentation or Bugfix

<-- Help us understand your motivation by explaining why you decided to make this change. We must be able to understand the purpose of your change from this description. Does this fix a bug? Does it close an issue? If so please mention it. -->

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @disassembler for double-checking.

@rphair rphair added the documentation Improvements or additions to documentation label Aug 28, 2024
@rphair rphair changed the title Use the latest version of the guardrails script Submitting governance actions: Use latest guardrails script Aug 28, 2024
@katomm katomm merged commit 3d5e336 into cardano-foundation:staging Aug 29, 2024
3 checks passed
@katomm
Copy link
Member

katomm commented Aug 29, 2024

I believe we are all in an agreement that based on contributions and reputation that @disassembler and @CarlosLopezDeLara have been added as a collaborator with write permissions on the repository so that their review counts as approval going forward.

@CarlosLopezDeLara
Copy link
Collaborator Author

@katomm I'm a bit puzzled. This is merged but I don't see the changes on the live site.

@rdlrt
Copy link
Collaborator

rdlrt commented Aug 30, 2024

Merged to staging, not main branch yet

@CarlosLopezDeLara
Copy link
Collaborator Author

Merged to staging, not main branch yet

I suppose this is automated. Is there a way for me to track it?

@katomm
Copy link
Member

katomm commented Aug 30, 2024

It is not automated. We often push to main branch Fridays, also today. It is live now.

Staging is visible on https://staging-dev-portal.netlify.app/ btw.

@katomm
Copy link
Member

katomm commented Aug 30, 2024

Note: We should consider doing releases for the developer portal like on cardano.org https://github.com/cardano-foundation/cardano-org/releases in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants