-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cardano audit script to builder tools #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Kirael12 - I would also recommend adding a getstarted:
page under the Operate a Stake Pool > Deployment Scenarios section ... could be a paraphrase of your introduction here: https://forum.cardano.org/t/new-cardano-node-security-compliance-audit-script-for-spos-all-setup/136189
hello @rphair do you mean adding a dedicated page getstarted: for the Tool, under Operate a Stake Pool > Deployment Scenarios section with a link to the tool as well ? (i though it was a bit redundant with the readme of the github). |
@Kirael12 I did already notice that your GitHub landing page was comprehensive and more-or-less the same as what you posted on the Cardano Forum. But still for SPOs looking for optional resources to configure their pools it would be good for it to be included with the other material you have written. So a "stub" that talks a bit less about it (just to introduce it mainly) & links to the more detailed instructions offsite would be fine. The main thing I think is getting this tool onto that Deployment Scenarios menu. |
@rphair Ok, i'm going to make a new page under Stake Pool > Deployment Scenarios section. I will create another dedicated Pull Request for this |
Add Deployment Scenarios -> Audit your node
Add a dedicated page for the audit-script in Deployment Scenarios section
add getstarted: for cardano-node-audit section
@rphair I created a new page under Deployment -> Scenarios, and added a link to getstared: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Kirael12 - just checked in a local build ✅ and it all looks & works great together. You have my double approval 😅
@rphair Hello :) I think there might be a problem with the merge, as the tool doesn't appear on tool page, and the new deployment scenario page seems to be missing as well |
"Merged" here means into staging-branch. It is reflected here: https://staging-dev-portal.netlify.app/docs/operate-a-stake-pool/audit-your-node |
@katomm My bad ! |
👋 Hello there! Welcome. Please follow the steps below to tell us about your contribution.
Checklist
<-- Please fill the boxes with [x] before submitting a pull request -->
yarn build
after adding my changes without getting any errors.yarn.lock
(or have removed these changes).Builder Tool addition
<-- Provide information for every bullet in the list below. The tags you select must match the tags in your changes to the builder-tools.js -->
cli
operatortool