-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid building crates with official pre-built artifacts? #197
Comments
@alsuren What do you think about this? |
I remember making quickinstall tell binstall not to look for upstream
builds, because it was too slow. This means that quickinstall will still
need us to build those packages.
Even if we managed to make it faster, we would need to wait for the
existing clients to die before disabling builds. I guess we could find that
out from the stats server, but binstall doesn't report which version of
quickinstall is driving it, so it might be guesswork.
In the grand scheme of things, we will always burn a bunch of compute time
building crates that nobody installs. I think we still break even overall
though (we could check by summing up the installs from the stats server and
comparing it against the how many crates we build in the same period).
…On Mon, 13 Mar 2023, 08:09 Jiahao XU, ***@***.***> wrote:
@alsuren <https://github.com/alsuren> What do you think about this?
—
Reply to this email directly, view it on GitHub
<#197 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB6FN2L2HJUXP6E2NXLLH3W33I2JANCNFSM6AAAAAAVYWL2AI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This is improved with v0.21.x release, which uses GitHub Restful API to speedup resolution and avoid creating a lot of http requests to GitHub that slows it down and gets it rate limited.
Hmm yeah, that's indeed a problem.
True. |
Let's put this issue to hold for now. |
I wonder if we should stop building crates with official pre-build artifacts.
We could use
cargo binstall --dry-run --strategies crate-meta-data "$crate" --targets "$TARGET_ARCH"
to find out if such artifacts are present.The text was updated successfully, but these errors were encountered: