Skip to content

Commit

Permalink
Make AD stack drive
Browse files Browse the repository at this point in the history
EgoVehicleControlInfo.msg
- Split data into junks
- Add control output
- Ego vehicle always sends out this message

Control behavior:
- Fix steering angle sign
- On speed target of zero, brake maximal (support fast emergency brake)
- Introduce max_pedal value to make range of acceleration and
deceleration pedal area more comparable as the pid control parameters
have to work for both
- Default PID values for pedal: increased proportional part to allow
faster adaptions
- Introduce min_accel border to disable (slow adatping) speed control if
high accelerations are required (support more exact stopping)

Others:
- Split rqt perspectives into AckermannControl and AckermannPlot
- Cleanup of launch files
- bridge.py is more verbose on publisher exceptions
- child.py get_param() forward default parameter to parent (fix)
- fix pitch angle sign (pitch has to be negative if the vehicle is
driving uphils)

-> the above results in ad stack able to drive including appropiate
stopping/starting uphils and downhils
  • Loading branch information
berndgassmann committed Dec 17, 2018
1 parent 3fdb842 commit 8b74f0e
Show file tree
Hide file tree
Showing 16 changed files with 886 additions and 218 deletions.
4 changes: 4 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@ catkin_python_setup()
add_message_files(
FILES
CarlaVehicleControl.msg
EgoVehicleControlCurrent.msg
EgoVehicleControlInfo.msg
EgoVehicleControlMaxima.msg
EgoVehicleControlState.msg
EgoVehicleControlTarget.msg
)

generate_messages(
Expand Down
1 change: 0 additions & 1 deletion client_with_rqt.launch
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<launch>
<include file="$(find carla_ros_bridge)/client.launch" pass_all_args="True"/>
<param name ="/use_sim_time" value="true"/>
<node pkg="rqt_gui" type="rqt_gui" name="rqt_gui" args="--perspective-file $(find carla_ros_bridge)/config/EgoVehicleControlInfo.perspective"/>
</launch>
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"keys": {
"running-plugins": {
"type": "repr",
"repr": "{u'rqt_reconfigure/Param': [1], u'rqt_plot/Plot': [3, 2, 1], u'rqt_topic/TopicPlugin': [1], u'rqt_publisher/Publisher': [1]}"
"repr": "{u'rqt_reconfigure/Param': [1], u'rqt_topic/TopicPlugin': [1], u'rqt_publisher/Publisher': [1]}"
}
},
"groups": {
Expand Down Expand Up @@ -150,7 +150,7 @@
},
"topics": {
"type": "repr",
"repr": "[u'/carla/ego_vehicle/ego_vehicle_control_info/target_speed_abs', u'/carla/ego_vehicle/ego_vehicle_control_info/current_speed_abs']"
"repr": "u''"
},
"y_limits": {
"type": "repr",
Expand Down Expand Up @@ -197,7 +197,7 @@
},
"topics": {
"type": "repr",
"repr": "[u'/carla/ego_vehicle/ego_vehicle_control_info/speed_control_accel_delta', u'/carla/ego_vehicle/ego_vehicle_control_info/speed_control_accel_target', u'/carla/ego_vehicle/ego_vehicle_control_info/current_accel']"
"repr": "u''"
},
"y_limits": {
"type": "repr",
Expand Down Expand Up @@ -244,7 +244,7 @@
},
"topics": {
"type": "repr",
"repr": "[u'/carla/ego_vehicle/ego_vehicle_control_info/accel_control_pedal_delta', u'/carla/ego_vehicle/ego_vehicle_control_info/throttle_lower_border', u'/carla/ego_vehicle/ego_vehicle_control_info/brake_upper_border', u'/carla/ego_vehicle/ego_vehicle_control_info/accel_control_pedal_target']"
"repr": "u''"
},
"y_limits": {
"type": "repr",
Expand Down Expand Up @@ -354,7 +354,7 @@
"keys": {
"publishers": {
"type": "repr",
"repr": "u\"[{'topic_name': '/carla/ego_vehicle/ackermann_cmd', 'type_name': 'ackermann_msgs/AckermannDrive', 'enabled': False, 'rate': 1.0, 'expressions': {u'/carla/ego_vehicle/ackermann_cmd/speed': '1'}, 'publisher_id': 0, 'counter': 0}]\""
"repr": "u\"[{'type_name': 'ackermann_msgs/AckermannDrive', 'topic_name': '/carla/ego_vehicle/ackermann_cmd', 'enabled': False, 'rate': 1.0, 'expressions': {u'/carla/ego_vehicle/ackermann_cmd/speed': '1'}, 'publisher_id': 0, 'counter': 0}]\""
}
},
"groups": {}
Expand All @@ -368,8 +368,8 @@
"keys": {
"tree_widget_header_state": {
"type": "repr(QByteArray.hex)",
"repr(QByteArray.hex)": "QtCore.QByteArray('000000ff00000000000000010000000000000000010000000000000000000000000000000000000479000000050101000100000000000000000500000064ffffffff0000008100000003000000050000018800000001000000030000011700000001000000030000007200000001000000030000003d00000001000000030000012b0000000100000003000003e800')",
"pretty-print": " d r = + "
"repr(QByteArray.hex)": "QtCore.QByteArray('000000ff00000000000000010000000000000000010000000000000000000000000000000000000728000000050101000100000000000000000500000064ffffffff000000810000000300000005000002c100000001000000030000022d00000001000000030000007200000001000000030000003d00000001000000030000018b0000000100000003000003e800')",
"pretty-print": " d - r = "
}
},
"groups": {}
Expand Down Expand Up @@ -457,8 +457,8 @@
},
"state": {
"type": "repr(QByteArray.hex)",
"repr(QByteArray.hex)": "QtCore.QByteArray('000000ff00000000fd00000001000000030000074900000482fc0100000009fb00000044007200710074005f00670072006100700068005f005f0052006f007300470072006100700068005f005f0031005f005f0052006f007300470072006100700068005500690100000000000003ef0000000000000000fb00000042007200710074005f006d00730067005f005f004d0065007300730061006700650073005f005f0031005f005f006d0065007300730061006700650073002e0075006901000003f5000002690000000000000000fc00000000000002820000026500fffffffc0200000003fb0000004c007200710074005f0074006f007000690063005f005f0054006f0070006900630050006c007500670069006e005f005f0031005f005f0054006f0070006900630057006900640067006500740100000000000001f60000007200fffffffb0000006c007200710074005f007200650063006f006e006600690067007500720065005f005f0050006100720061006d005f005f0031005f005f005f0070006c007500670069006e0063006f006e007400610069006e00650072005f0074006f0070005f00770069006400670065007401000001fc0000019d0000010f00fffffffb00000058007200710074005f007000750062006c00690073006800650072005f005f005000750062006c00690073006800650072005f005f0031005f005f005000750062006c00690073006800650072005700690064006700650074010000039f000000e30000009300fffffffb0000005a007200710074005f0069006d006100670065005f0076006900650077005f005f0049006d0061006700650056006900650077005f005f0031005f005f0049006d00610067006500560069006500770057006900640067006500740100000434000003070000000000000000fb0000004c007200710074005f00740066005f0074007200650065005f005f0052006f0073005400660054007200650065005f005f0031005f005f0052006f0073005400660054007200650065005500690100000147000002200000000000000000fb0000004c007200710074005f00740066005f0074007200650065005f005f0052006f0073005400660054007200650065005f005f0032005f005f0052006f007300540066005400720065006500550069010000058e000001ad0000000000000000fb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0031005f005f00440061007400610050006c006f007400570069006400670065007401000002880000017b0000017800fffffffb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0032005f005f00440061007400610050006c006f00740057006900640067006500740100000409000001c20000017800fffffffb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0033005f005f00440061007400610050006c006f007400570069006400670065007401000005d1000001780000017800ffffff000007490000000000000004000000040000000800000008fc00000001000000030000000100000036004d0069006e0069006d0069007a006500640044006f0063006b00570069006400670065007400730054006f006f006c0062006100720000000000ffffffff0000000000000000')",
"pretty-print": " Drqt_graph__RosGraph__1__RosGraphUi Brqt_msg__Messages__1__messages.ui e r 4 G { x x x x I "
"repr(QByteArray.hex)": "QtCore.QByteArray('000000ff00000000fd00000001000000030000074900000482fc0100000009fb00000044007200710074005f00670072006100700068005f005f0052006f007300470072006100700068005f005f0031005f005f0052006f007300470072006100700068005500690100000000000003ef0000000000000000fb00000042007200710074005f006d00730067005f005f004d0065007300730061006700650073005f005f0031005f005f006d0065007300730061006700650073002e0075006901000003f5000002690000000000000000fc00000000000007490000026500fffffffc0200000003fb0000004c007200710074005f0074006f007000690063005f005f0054006f0070006900630050006c007500670069006e005f005f0031005f005f0054006f0070006900630057006900640067006500740100000000000002290000007200fffffffb0000006c007200710074005f007200650063006f006e006600690067007500720065005f005f0050006100720061006d005f005f0031005f005f005f0070006c007500670069006e0063006f006e007400610069006e00650072005f0074006f0070005f007700690064006700650074010000022f0000016a0000010f00fffffffb00000058007200710074005f007000750062006c00690073006800650072005f005f005000750062006c00690073006800650072005f005f0031005f005f005000750062006c00690073006800650072005700690064006700650074010000039f000000e30000009300fffffffb0000005a007200710074005f0069006d006100670065005f0076006900650077005f005f0049006d0061006700650056006900650077005f005f0031005f005f0049006d00610067006500560069006500770057006900640067006500740100000434000003070000000000000000fb0000004c007200710074005f00740066005f0074007200650065005f005f0052006f0073005400660054007200650065005f005f0031005f005f0052006f0073005400660054007200650065005500690100000147000002200000000000000000fb0000004c007200710074005f00740066005f0074007200650065005f005f0052006f0073005400660054007200650065005f005f0032005f005f0052006f007300540066005400720065006500550069010000058e000001ad0000000000000000fb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0031005f005f00440061007400610050006c006f007400570069006400670065007401000002880000017b0000000000000000fb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0032005f005f00440061007400610050006c006f00740057006900640067006500740100000330000002380000000000000000fb00000042007200710074005f0070006c006f0074005f005f0050006c006f0074005f005f0033005f005f00440061007400610050006c006f0074005700690064006700650074010000049a000002af0000000000000000000007490000000000000004000000040000000800000008fc00000001000000030000000100000036004d0069006e0069006d0069007a006500640044006f0063006b00570069006400670065007400730054006f006f006c0062006100720000000000ffffffff0000000000000000')",
"pretty-print": " Drqt_graph__RosGraph__1__RosGraphUi Brqt_msg__Messages__1__messages.ui I e ) r / j 4 G { 0 8 I "
}
},
"groups": {
Expand Down
Loading

0 comments on commit 8b74f0e

Please sign in to comment.