-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case when the registry link for pull is a image but the flags are -I along with —image-is-bundle-check flag=true which results in the image being pulled. #559
Comments
Hey @ashpect, I think there is a some confusion around the --image-is-bundle-check Error when image is a bundle (disable pulling bundles via -i) (default true) So the expectation is
|
Thanks for the input. I'll change the fix accordingly. However, regarding this current opened issue : |
The flag |
Hmm..thanks, understood. I was just hung up on the fact that the user might use flag with true confusing himself. But understood that the flag is not meant for setting as false, its default being true. |
Closing this issue, but let me know if you have any other questions. |
What steps did you take:
Pls see #544 for context.
During my attempt to fix #544 and my analysis of all the cases and the flow of code with the flags.
I have opened a PR with a suggestive fix.
What happened:
It seems like the case when the link it image but the flags are -I along with —image-is-bundle-check flag=true results in the image being pulled.
What did you expect:
An error when I pass the wrong flag with link of an image.
Environment:
/etc/os-release
):Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: