You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# carvel.dev/imgpkg/pkg/imgpkg/registry
pkg/imgpkg/registry/registry.go:202:36: cannot use 9999999999 (untyped int constant) as int value in argument to rand.Intn (overflows)
What did you expect:
It builds w/o problems.
Anything else you would like to add:
imgpkg is not distributed for */386. That's not something we need to change. However, since carvel.dev/imgpkg can be consumed as a library, it should be compatible.
Environment:
imgpkg version (use imgpkg --version): n/a
Docker registry used (e.g. Docker HUB): n/a
OS: windows/386
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered:
Technically, this reduces the set from which session IDs are drawn by
(9.999.999.999 - 2.147.483.647) = 7.852.516.352, say 75%.
Practically, ~2 million should large enough to avoid collisions in the
real-world.
This fixes an int overflow for 386 architectures.
Fixescarvel-dev#663
Signed-off-by: Max Brauer <mbrauer@vmware.com>
Technically, this reduces the set from which session IDs are drawn by
(9.999.999.999 - 2.147.483.647) = 7.852.516.352, say 75%.
Practically, ~2e10 possible session IDs should be large enough to avoid
collisions in the real-world.
This fixes an int overflow for 386 architectures.
Fixescarvel-dev#663
Signed-off-by: Max Brauer <mbrauer@vmware.com>
What steps did you take:
Build for, say,
windows/386
:What happened:
Int overflow. 🤖 💀
What did you expect:
It builds w/o problems.
Anything else you would like to add:
imgpkg
is not distributed for*/386
. That's not something we need to change. However, sincecarvel.dev/imgpkg
can be consumed as a library, it should be compatible.Environment:
imgpkg --version
): n/aDocker HUB
): n/awindows/386
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: