-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when --image-is-bundle-check flag is set to false while using -b flag #563
Conversation
Signed-off-by: ashpect <ashishndiitr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @ashpect. The change looks good to me. Would you like to add a test for this as well?
Yes, definitely. |
Hello @praveenrewar. I added a test for the fix. |
Signed-off-by: ashpect <ashishndiitr@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This solves #544
Issue
The command
successfully runs and will pull it as an image, which is a bit weird because we are trying to pull a bundle using the bundle flag.
Fix
Now running the command throws this error